Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: heartbeat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897 ------- Additional Comments From orion@xxxxxxxxxxxxx 2006-02-28 18:58 EST ------- (In reply to comment #35) > W: heartbeat unstripped-binary-or-object /usr/bin/cl_status > - I do not know how to fix. Is this warning safe to ignore? I can't reproduce, might be a local build issue. > W: heartbeat dangling-symlink /etc/ha.d/resource.d/ldirectord /usr/sbin/ldirectord > The symbolic link points nowhere. > - I do not know how to fix. Is this warning safe to ignore? > The link is in both heartbeat and heartbeat-ldirectord. Remove from heartbeat: --- heartbeat.spec.orig 2006-02-28 15:38:00.000000000 -0700 +++ heartbeat.spec 2006-02-28 16:50:52.000000000 -0700 @@ -200,6 +200,7 @@ %{_libdir}/libstonithd.so.* %{_prefix}/lib/ocf %{_sysconfdir}/ha.d/resource.d/ +%exclude %{_sysconfdir}/ha.d/resource.d/ldirectord %{_sysconfdir}/init.d/heartbeat %config(noreplace) %{_sysconfdir}/logrotate.d/heartbeat %dir %{_var}/lib/heartbeat > W: heartbeat dangerous-command-in-%postun userdel > - I do not know how to fix. Is this warning safe to ignore? As above, don't delete the user. > W: heartbeat-ldirectord devel-file-in-non-devel-package > /usr/sbin/supervise-ldirectord-config > A development file (usually source code) is located in a non-devel > package. If you want to include source code in your package, be sure to > create a development package. > - I think this is an error on the part of rpmlint. I can not > see any reason this file would be flagged as a > 'development file', while it isn't. Agreed. > E: heartbeat-ldirectord incoherent-logrotate-file /etc/logrotate.d/ldirectord > Your logrotate file should be named /etc/logrotate.d/<package name>. > - Agree with the error, but changing /etc/logrotate.d/ldirectord > to /etc/logrotate.d/heartbeat-ldirectord would mean changing a > lot of non-trivial things in source package. Can we safely ignore > this? > > W: heartbeat-ldirectord incoherent-init-script-name ldirectord > The init script name should be the same as the package name in lower case. > - same as above. Can we safely ignore this? > Yes, or alternative is to name the subpackage "ldirectord" instead of "heartbeat-ldirectord". %package -n ldirectord does this (and same for %files, %post, etc). Might be a good idea if it seems likely that this will be split off (the description indicates that it is "standalone"). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
