Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: heartbeat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180897 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-02-28 17:37 EST ------- (In reply to comment #35) > remaining rpmlint issues: > > W: heartbeat unstripped-binary-or-object /usr/bin/cl_status > - I do not know how to fix. Is this warning safe to ignore? Why isn't it stripped? What permissions does it get installed with? > W: heartbeat dangling-symlink /etc/ha.d/resource.d/ldirectord /usr/sbin/ldirectord > The symbolic link points nowhere. > - I do not know how to fix. Is this warning safe to ignore? This symlink is explicitly created in the spec file: ( cd $RPM_BUILD_ROOT/etc/ha.d/resource.d ln -s /usr/sbin/ldirectord ldirectord ) Is it pointing from the right place to the right place? > W: heartbeat dangerous-command-in-%postun userdel > - I do not know how to fix. Is this warning safe to ignore? Don't delete user or group accounts on package deletion, leave them there. > W: heartbeat-ldirectord devel-file-in-non-devel-package > /usr/sbin/supervise-ldirectord-config > A development file (usually source code) is located in a non-devel > package. If you want to include source code in your package, be sure to > create a development package. > - I think this is an error on the part of rpmlint. I can not > see any reason this file would be flagged as a > 'development file', while it isn't. It's probably the "-config" suffix of the name (without looking at the rpmlint code). Looks bogus to me too. > E: heartbeat-ldirectord incoherent-logrotate-file /etc/logrotate.d/ldirectord > Your logrotate file should be named /etc/logrotate.d/<package name>. > - Agree with the error, but changing /etc/logrotate.d/ldirectord > to /etc/logrotate.d/heartbeat-ldirectord would mean changing a > lot of non-trivial things in source package. Can we safely ignore > this? Why wouldn't it just be a "mv"? Having said that, heartbeat-ldirectord is a bit of a mouthful. > W: heartbeat-ldirectord incoherent-init-script-name ldirectord > The init script name should be the same as the package name in lower case. > - same as above. Can we safely ignore this? I'd say so, yes. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
