Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Spiffy https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183028 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-02-26 00:36 EST ------- OK, the package looks great. I've thought about the Provides: perl(mixin) a bit; just to explain it for posterity: Various modules using this one will make use of the syntax: use mixin 'package'; which will cause Perl's dependency generator to decide that the package requires perl(mixin). Since this package (perl-Spiffy) is the package that enables that syntax even though RPM's automatic Provides: generation doesn't detect it, it makes sense to add Provides: perl(mixin) here. The bad: Source matches upstream. However, I can't fetch the source from the provided URL. I needed to use http://search.cpan.org/CPAN/authors/id/I/IN/INGY/Spiffy-0.30.tar.gz instead. The Summary: is problematic. How about "A framework for doing object orinted programming in Perl" instead? The good: Package builds and passes tests in mock (development, i386 and x86_64). rpmlint is silent. The specfile is clean and well written. The license is appropriate, matches upstream and is included as %doc. I'll approve if you fix the Source0: URL and the Summary:. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
