Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SS5 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182254 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-02-25 18:23 EST ------- See the packaging guidelines for most of these: http://fedoraproject.org/wiki/Packaging/Guidelines A few things need to be worked on: * rpm chokes on your Copyright tag. This should be changed to License, and changed to the accepted acronym, GPL. * I don't understand the mr1 part of the Release tag. Read the naming guidlines to see examples when this can be used. http://fedoraproject.org/wiki/Packaging/NamingGuidelines * Define the recommended Buildroot * Your %files directive lists a binary in /opt. Move it out of there, it's not even on the path. * Many directives are after the %changelog. This may work, but it's against convvention, nearly every other package does %changelog last. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
