Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-geoip - Python bindings for the GeoIP geographical lookup libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181979 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-02-19 11:06 EST ------- A clean package, builds fine in mock on i386 and x86_64. However, I don't think the name is proper. By my understanding of the naming guidelines, your package should be python-GeoIP. rpmlint says: W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_city.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_org.py /usr/bin/python W: python-geoip doc-file-dependency /usr/share/doc/python-geoip-1.2.1/test_region.py /usr/bin/python This is the rpm dependency generator picking up a /usr/bin/python dependency from the executable scripts marked %doc. In this case I believe the added dependency is just redundant since python is required anyway and there's no prohibition against executable documentation that I can fine, but if you want to quiet rpmlint, just chmod -x the files. Note also that three of the example files will not work at all with the (free) GeoIP package in Extras. I don't think this is a blocker, but it may generate bug reports. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
