Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gallery: web based photo album software https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599 ------- Additional Comments From imlinux@xxxxxxxxx 2006-02-15 03:33 EST ------- -Provide full path to source -Don't use Requires(hint) -Inconsitant use of $RPM_BUILD_ROOT (also used as ${RPM_BUILD_ROOT}) -defattr in %files is way off. You'll end up with dir's that aren't executable. put one %defattr(-,root,root,-) right under %files, get rid of the two that are there. -empty %build section (remove it) -Don't use hard coded paths, use macros: http://fedoraproject.org/wiki/Extras/RPMMacros -Group Applicaton/System is not a valid Fedora group -Put a version/release tag in your change logs -If this is a gallery2-minimal tarbal why not make a gallery2-minimal rpm? -Are you sponsored? -Please download rpmlint and run it against the rpm you generate -Take a look at: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines It'll help if you know all the criteria that we review on. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
