Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: smart -- Next generation package handling tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175438 ------- Additional Comments From Axel.Thimm@xxxxxxxxxx 2006-01-26 03:36 EST ------- That's a long list in comment #58 compared to the just-three-items-left list a couple of days ago. :( We don't need to make smart *the perfect package*, it's more important to get its review finalized, before Enrico gets pissed off too much. But I'd like to comment on the suggestion to use macros for make/test etc. For one using a macro there would not replace a Requires:. Either the package in question is in the default Requires: list, or it needs to be set as a dependency independently of whether you use macros to obfuscate the specfile. And I already mentioned the second part about macros: If all they do is replace make with %{__make} then all they do is obfuscate the specfile beyond recognition. Please don't do that! You may argue that %{__foo} will have an absolute path and is therefore safer etc., but the build itself has to be assumed to be in a safe environment and for packages submitted here even in a minimal chroot w/o any broken remnants under /usr/local. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
