Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: smart -- Next generation package handling tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175438 ------- Additional Comments From jarkko@xxxxxxxxxxxxx 2006-01-23 14:45 EST ------- I have only one thing I'd like to see changed in the spec file before it is approved: I strongly think packages should always state all their dependencies. You should not assume anything. Smart requires rpm-python (well, at least in fedora it does), in this case >= 4.3 (or is it 4.4 after all?). That should be in the spec file. rpm-build >= 4.3 should be in build requirements because older versions won't build this package (was it 4.3 or 4.4?). I suggest adding these for the main package: Requires: rpm-python >= 4.3 BuildRequires: rpm-build >= 4.3 Other than this, I'd say the spec is ok and ready for release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
