Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Azureus - a BitTorrent Client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178330 chabotc@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From chabotc@xxxxxxxxx 2006-01-19 14:21 EST ------- New reviewlist based on release 12: MUST review items: - Builds cleanly on FC5 devel. - Source included doesn't match upsteam source, but for a good reason :-) - Package name meets guidelines - spec file name is in %{name}.spec format - Licence is fedora extra's compatible & is included - Spec file is in (american) english - Does not list buildrequires that are excepted in the package guidelines - All build dependencies are listed - No ldconfig needed - All files have proper permissions - Package is not relocatable - No duplicate files in %files section - No missing files in %files section - Has a proper %clean section with rm -rf $RPM_BUILD_ROOT - Uses macro's described in PackagingGuidelines - No entries in %doc that are required for standard program operation - No -devel package needed - Proper directory-ownerships - Correct desktop file & install handling & categories Should items: - Includes upstream licence(s) file - No insane scriplets - No unnescesarry requires - Mock build cleanly (fedora-devel-i386) I've even tried to compile w/o junit, but can tell you that Azureus does depend on it (azureus-2.3.0.6/org/gudy/azureus2/ui/console/multiuser/TestUserManager.java), the how and what and why i will leave to AG, i'm not skilled in java enough to comment on this, but this isn't a packaging issue, more something for future bugzilla reports (i'm sure quite a few of those will follow, but better to do that in bugzilla/cvs). So: FE-ACCEPTED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
