Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: JACAL: an interactive symbolic mathematics program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169169 ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2006-01-15 11:05 EST ------- MUST items that pass: - rpmlint runs fine on output without errors or warnings - package name according to guidelines - spec file name OK - meets PackagingGuidelines - license open-source - License field matches license - license text in upstream and included - spec file in American English - spec file legible - source matches upstream - package builds on FC4-i386 - no BuildRequires - no locales - no shared libraries - not relocatable - no duplicate files - file permissions OK - %clean section OK - contains code - no large documentation - docs don't affect the running application - no -devel required - not a GUI application SHOULD items that pass: - license included in upstream - package builds in mock for FC4-i386 - arch-independent, so it probably builds on all arches - package installs and the jacal binary runs - no subpackages Suggestions and problems: - the package should own %{_datadir}/jacal - Summary field should better use words beginning with lowercase letters - Source field should better use %{version} - Use $RPM_BUILD_ROOT instead of ${RPM_BUILD_ROOT} - Use "install -d" instead of "mkdir -p" - Use "cp -p" for copying files - Create 'guile.scm', 'go.scm', and the jacal binary using SourceN - ratint.tex (in docs) is probably unnecessary, as it is a source of ratint.pdf, which is also included. we shouldn't need to pack sources in RPMs Questions: During rpmbuild, I get an error in the %install process: Makefile:33: srcdir.mk: No such file or directory What is this? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
