[Bug 176542] Review Request: gnome-yum - GNOME interface for YUM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-yum - GNOME interface for YUM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=176542





------- Additional Comments From chabotc@xxxxxxxxx  2006-01-14 12:51 EST -------
Thanks that solves all the issues reported

However it looks like you modified the source.tar.bz2 file? MD5SUM now missmatches

md5sum:
43e4f678a9243c92297f0929e7d87efe  (original from sf.net) gnome-yum-0.1.2.tar.bz2
bc105a3711409e8bdd66522caa59b316  (from src.rpm) gnome-yum-0.1.2.tar.bz2

I presume you've done this to include the X-Fedora category? Might be easier to
use the original source and in your spec file do:

desktop-file-install --vendor fedora --delete-original       \                 
                                             
  --dir $RPM_BUILD_ROOT%{_datadir}/applications             \    
  --add-category X-Fedora \                                                    
       
  $RPM_BUILD_ROOT%{_datadir}/applications/gnome-yum.desktop    

It is a strict policy for Fedora Extra's that source tarbal must match the
original one (checked with md5sum) so unfortunatly i can't accept this package yet.

Please either update the upstream tarbal, or use the original one and add the
--add-category X-Fedora to the desktop-file-install

Other then that its looking great, and builds cleanly in mock too. I will give
it the formal review once the source tarbal issue is resolved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

-- 
fedora-extras-list mailing list
fedora-extras-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-extras-list

[Index of Archives]     [Fedora General Discussion]     [Fedora Art]     [Fedora Docs]     [Fedora Package Review]     [Fedora Desktop]     [Big List of Linux Books]     [Yosemite Backpacking]     [KDE Users]

  Powered by Linux