Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: smb4k - The SMB/CIFS Share Browser for KDE https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177567 gajownik@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gdk@xxxxxxxxxx |gajownik@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From gajownik@xxxxxxxxx 2006-01-14 12:44 EST ------- (In reply to comment #2) > I have added kdebase-devel to BR. I'll think about > “--disable-dependency-tracking --enable-final”, thanks for info. I found some more info about these options → http://www.kadu.net/forum/viewtopic.php?t=6607 (in Polish ;] ) http://lists.kde.org/?l=kde-devel&m=99197154828408&w=2 These options are useful for packagers but not for the developers so it would be nice to turn them on :D Things that need some work: - *.desktop file does not have “MimeType” tag so you don't have to run `update-desktop-database' https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177588#c3 (please don't forget to remove unneeded Requires) - you may want to change “/etc/profile.d/qt.sh” to “%{_sysconfdir}/profile.d/qt.sh” - broken libtool archive: [y4kk0@X i386]$ rpmlint smb4k-0.6.5-2.i386.rpm E: smb4k invalid-directory-reference /usr/lib/kde3/konqsidebar_smb4k.la W: smb4k dangling-relative-symlink /usr/share/doc/HTML/en/smb4k/common ../common [y4kk0@X i386]$ For example on my machine “dependency_libs” variable from that file contains "-L/home/y4kk0/rpmbuild/BUILD/smb4k-0.6.5/smb4k/core -L/home/y4kk0/rpmbuild/BUILD/smb4k-0.6.5/smb4k/widgets". I'll try to investigate it further. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
