Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mysql-connector-net https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177512 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-01-12 13:03 EST ------- Don't use "%{__rm} -rf *" in %prep; it'll clobber any other package builds going on in the same build area. Instead of: %prep %{__mkdir} -p %{name}-%{version} %{__rm} -rf * %{__unzip} -q %{SOURCE0} -d %{name}-%{version} %{__cp} %{SOURCE1} %{name}-%{version} I'd suggest: %prep %setup -c -q %{__cp} %{SOURCE1} . By doing this you can also remove the "cd %{name}-%{version}" from the start of %build. I'd also suggest replacing the hardcoded "1.0.7" in the Source0 URL with "%{version}" to ease future package updates, and please word-wrap %description so that it's no longer than 80 characters per line. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. -- fedora-extras-list mailing list fedora-extras-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-extras-list
