On Wed, 2008-03-05 at 13:15 -0500, Colin Walters wrote: > On Wed, 2008-03-05 at 13:11 -0500, Tom "spot" Callaway wrote: > > On Wed, 2008-03-05 at 13:03 -0500, Colin Walters wrote: > > > Hi, > > > > > > I've spent a little bit of time on the shuttle to/from work hacking on > > > Makefile.common. The general idea is to remove the Release: and % > > > changelog fields from spec files, and have them generated automatically. > > > > Changelog I might buy into, but Release? There are too many complicated > > cases (Pre/Post immediately spring to mind) to automatically do this. > > Can you explain what the problem is with Pre/Post? How will the Makefile know whether the package is a Pre or Post release package? See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-5ea39bbc33cf351b41b51325ac3527eff4c58dac > > Also, we'd be forcing a hardcoded dist tag here. > > There's nothing hardcoded; you should be able to override it. + (echo -n "Release: " && echo $${release}$(DIST) ... You're hardcoding the value of the dist tag by default into the spec, then generating the SRPM. That means that the SRPM will always have that dist value, even if it is rebuilt. Also, since this seems to happen on build operations, it means that packages get a dist tag, even if the packager doesn't want one. :( ~spot -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list
