On Fri, 01 Jun 2007 12:38:41 -0700, Toshio Kuratomi wrote: > On Fri, 2007-06-01 at 20:32 +0530, Rahul Sundaram wrote: > > Hans de Goede wrote: > > > > > > Not true many reviewers review on the latest stable, it says nowhere > > > that a review should be done on rawhide. > > > > Review is about guidelines and nowhere in the guideline does it even say > > that the fucntionality of the package should be tested. When I suggested > > that it be added I got back a knee jerk reaction to participate in > > reviews myself. > > > http://fedoraproject.org/wiki/Packaging/ReviewGuidelines:: > > - SHOULD: The reviewer should test that the package functions as > described. A package should not segfault instead of running, for > example. And it has been part of the guidelines for a *very* long time, simply to reduce the risk that something is built that refuses to work because of very obvious problems. It is easy to build packages that install fine, but which contain programs that don't even start without problems. A typical mistake with graphical applications is a "Help" menu item which doesn't work because of misplaced or missing documentation files. -- fedora-devel-list mailing list fedora-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-devel-list