Re: Non-standard options removal from %cmake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vitaly Zaitsev via devel venit, vidit, dixit 2025-03-12 12:43:05:
> Hello.
> 
> Non-standard options removal[1] from %cmake macros broke various 
> packages in Rawhide[2].
> 
> Some projects still use LIB_SUFFIX and LIB_INSTALL_DIR. They are all 
> FTBFS now.
> 
> This change was done without proper announcement. Please revert or make 
> it a system-wide change.
> 
> [1]: 
> https://src.fedoraproject.org/rpms/cmake/c/ae4f1fd8691c484b09cf526dde74b67d12bdd9e3?branch=rawhide
> [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2351130
> 

Interesting.

This is also a perfect example of how *not* to write git commit nor
changelog messages: everybody who can read those few lines of diff will
know what got removed and that it wasn't "standard" (or else it would
not have been defined manually); but the "why" is not adressed, nor is
it obvious.

In fact, even more got removed:

-         -DINCLUDE_INSTALL_DIR:PATH=%{_includedir} \\\
-         -DLIB_INSTALL_DIR:PATH=%{_libdir} \\\
-         -DSYSCONF_INSTALL_DIR:PATH=%{_sysconfdir} \\\
-         -DSHARE_INSTALL_PREFIX:PATH=%{_datadir} \\\

How are we supposed to ensure Fedora standard install paths with cmake
in spec? Is everyone supposed to set them? Are other (buildroot?)
packages setting them in a way which cmake picks up?

Michael
-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux