Hello, Zbigniew, thanks for updating the audit events. On Tuesday, January 14, 2025 5:56:01 AM EST Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Jan 13, 2025 at 02:02:33PM +0100, Iker Pedrosa wrote: > > > Which shadow-utils upstream ticket? > > https://github.com/shadow-maint/shadow/issues/940 > > > I've long wanted to get rid of the patch we have in Fedora for shadow > > audit, either by including it upstream or removing it altogether, but > > I'm afraid it may affect our user's systems. Maybe this FSWC will be the > > trigger for such a change. > > This is separate topic. Anyway, based on what Steve wrote, the patch > cannot be removed. Right. But I see a possible minimal patch to fix it. https://github.com/shadow-maint/shadow/blob/master/lib/audit_help.c#L59 This ^^^ function logs all audit events, In all cases what needs to be fixed is the op field. There could be a patch for that function that looks for white spaces in the op field and replaces it with a hyphen. Then all that's left is reviewing that their op fields throughout the code haven't diverged from our patch. I'll look into sending them a patch to fix the first issue. Reviewing all events will take longer to get to. -Steve -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
