On Tue, Jan 14, 2025 at 1:29 PM Vít Ondruch <vondruch@xxxxxxxxxx> wrote: > > > Dne 14. 01. 25 v 16:21 Zbigniew Jędrzejewski-Szmek napsal(a): > > On Tue, Jan 14, 2025 at 11:36:59AM +0100, Vít Ondruch wrote: > >> Hi, > >> > >> Is there any convention for naming patches? I mildly remember that there > >> used to be some guideline suggesting form such as > >> `pagkage-name-version-description-of-patch.patch`. But I was not able to > >> find this codified in guidelines. > > Coordinated naming of patches (and sources, and other files) used to > > matter when people dumped them in a shared directory like > > ~/rpmbuild/SOURCES/. > > > Yes, I remember something like this was the reason. But not sure if this > was just verbally shared knowledge or if there was any official guideline. > > > > I really really hope nobody does that anymore. > > > I have no hopes ;) > > > > > > When files are stored in individual directories, in the usual dist-git > > layout, then the naming is up to the maintainers. In particular, > > NNNN-description-with-dashes.patch is often used, since this is > > what 'git format-patch' generates. But there is no need for guidlines > > to prescribe any naming. > > > But the opposite guideline, such as "there is no official patch naming > convention, feel free to use whatever works for you" would also help 😇 > I personally use a numbering scheme to split up backports, proposed upstream changes, and downstream only changes. Usually, 0001~0500 are upstream backports, 0501~1000 are proposed changes, and 1001+ are downstream only. Occasionally, I explicitly do not use git-am formatted filenames for downstream patches because they are never intended for upstreaming and I like tracking the package name+version they were written/updated to. I refuse to use source-git, as I find it problematic, but I use "-S git_am" to apply patches since I get bisectable trees when I need to debug things. -- 真実はいつも一つ!/ Always, there's only one truth! -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue