Adam Williamson wrote:
> The situation in the old code was actually rather more complicated, and
> weird, than "the non-settable threshold was fixed to the wrong value" -
> there were multiple check functions that applied different logic to
> different operations, which is why you could sometimes push something
> via the CLI that you could not push via the web UI, for e.g.
Indeed, and I believe this is actually the explanation for the following:
> *This* is the point at which a minimum of +2 was introduced for non-
> critpath updates (after Beta freeze). The commit message does not
> reference any FESCo decision. It says "This matches what bodhi seems to
> implement and the text before my changes said", but I don't believe
> either of those things is accurate: it does not really match what the
> text before his changes said (it did not clearly prescribe +2 for non-
> critpath), and it does not really match old Bodhi behaviour (which was
> weird and inconsistent, but *could* be made to push a non-critpath
> update with only +1 karma).
In fact, I vaguely recall that some version(s) of Bodhi had a hardcoded
check that would mark any update as approved for manual push when the
hardcoded minimum requirements for critpath were met. As a result, if, for
an update, the default stable threshold of +3 was not changed (or if a
higher threshold was set), Bodhi would actually have marked the update as
approved at +2 because of the hardcoded check. So that is where the +2
probably came from.
So it is a combination of multiple Bodhi glitches that ended up accidentally
encoded in the documentation and now made it back into Bodhi in a strict
reinterpretation.
I think it kinda makes critpath pointless if we now require the same +2
threshold for all updates.
Kevin Kofler
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
