Re: FYI Koji 1.35 changed how side tag newRepo works

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard W.M. Jones wrote:
>   fedpkg build --target=... --wait-build=<build>

Neither "man fedpkg" nor "fedpkg build --help" mention a "--wait-build"
option.

Michael McLean wrote:
> In most cases where folks are using the wait-repo command, they would
> probably be better off passing either `--wait-repo` or `--wait-build=NVR`
> to the build command (the latter can be given multiple times). This will
> cause the build itself to do the waiting. (These are not new options,
> they've been in place for a few years now)

"koji build --help" at least mentions those options, but their
descriptions are rather unclear. It's not explained whether they
request a refresh or just wait for it to happen. Nor is it explained
whether they wait before or after building the package.

In the case of --wait-repo it would make sense to request and await a
refresh after the build, to guarantee that when the koji command exits
successfully the repo includes the newly built package and is ready for
the next command in a list. It would also make sense to request and
await a refresh before building, if it's known that all the needed
packages have been built and tagged but the repo may need refreshing.

In the case of --wait-build, waiting for a specific other package after
the build would seem a bit odd, so I would guess that it first waits
for the specified package to appear, then requests a refresh, waits for
that, and then performs the build.

If FedPKG actually has a --wait-build option like Richard wrote, then I
really hope that both --wait-build options do the same things.

I would prefer to have all of that clearly documented, rather than
hoping that what makes sense to me also made sense to the people who
wrote the Koji client and FedPKG.

Petr Pisar wrote:
>       --request          Create a repo request (requires auth)
>       --no-request       Do not create a repo request (the default)

Those descriptions are even more unhelpful. Before this email thread I
wouldn't have known what a "repo request" is or why I would want to
create one. "Request refreshing the repo" would have been clearer.

Björn Persson

Attachment: pgpDBZzMDFXi2.pgp
Description: OpenPGP digital signatur

-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux