In most cases where folks are using the wait-repo command, they would probably be better off passing either `--wait-repo` or `--wait-build=NVR` to the build command (the latter can be given multiple times). This will cause the build itself to do the waiting. (These are not new options, they've been in place for a few years now)
On Tue, Oct 22, 2024 at 1:25 PM Adam Williamson <adamwill@xxxxxxxxxxxxxxxxx> wrote:
On Tue, 2024-10-22 at 16:11 +0100, Richard W.M. Jones wrote:
> [So no one else ends up waiting around like an idiot]
>
> Koji 1.35 changed how repositories and side tags and such get rebuilt,
> so they no longer get rebuilt on their own. Instead you have to *either*:
>
> fedpkg build --target=... --wait-build=<build>
>
> *or*:
>
> koji wait-repo <tag> --build=<build> --request
>
> where the --request option (I think implied in the first command) will
> both request that the repository is recreated and wait for it.
>
> Rich.
Hmm. I think some code and docs may need to be updated for this.
Bodhi has bodhi.client.cli._generate_wait_repo_command , which produces
a command of the format `koji wait-repo <tag> --build=<build>` - no `--
request` - which it uses to print a hint when you create a buildroot
override, and which it actually runs if you pass --wait when creating a
buildroot override.
fedpkg - via rpkg - prints a hint "Use 'koji wait-repo f41-build-side-
7863' to wait for the build repo to be generated." when you create a
side tag. The code for that is in rpkg, pyrpkg/cli.py . The Package
Update Guide doc -
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Update_Guide/#multiple_packages
- shows a sample `fedpkg request-side-tag` command which includes this
output, and then says "The latter is important if any builds depend on
previous ones in the side tag. Use `koji wait-repo --build <package-
nvr> <side-tag>` to ensure that the respective build is available in
the build root for subsequent builds."
Do we need to update some or all of those? If so, who wants to do it?
:)
--
Adam Williamson (he/him/his)
Fedora QA
Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@xxxxxxxxxxxxx
https://www.happyassassin.net
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
