Old Style Dependency Generators

[Vít Ondruch <vondruch@xxxxxxxxxx>]

For ages, I had opened this PR [1] which was recently closed. This made 
me to dig into this a bit and it seems there is still quite a lot of 
packages using the old style dependency generators. I'd suggest to 
update those to the modern generators. The list of the affected packages 
is here:


~~~

$ grep -R filter_setup | wc -l
86

$ grep -R filter_setup
audacious-plugins.spec:%filter_setup
cvs2cl.spec:%{?filter_setup:
dhcp.spec:%{filter_setup}
dmlite.spec:%filter_setup
dyninst.spec:%{?filter_setup:
dyninst.spec:%filter_setup
fcitx-qt5.spec:%filter_setup
get_iplayer.spec:- conditionalise %%filter_setup properly.
glusterfs.spec:# filter_setup exists in RHEL6 only
glusterfs.spec:%filter_setup
gr-osmosdr.spec:%{?filter_setup:
gr-osmosdr.spec:%filter_setup
highlight.spec:%{?filter_setup:
highlight.spec:%filter_setup
hplip.spec:%{?filter_setup:
hplip.spec:%filter_setup
hypre.spec:%{?filter_setup:
hypre.spec:%filter_setup
Io-language.spec:%filter_setup
ldns.spec:%{?filter_setup:
ldns.spec:%filter_setup
libcouchbase.spec:%{?filter_setup}
libdasm.spec:%{?filter_setup:
libdasm.spec:%filter_setup
libkolabxml.spec:%{?filter_setup:
libkolabxml.spec:%filter_setup
libkolabxml.spec:%{?filter_setup:
libkolabxml.spec:%filter_setup
libkolabxml.spec:%{?filter_setup:
libkolabxml.spec:%filter_setup
libpst.spec:%{?filter_setup:
libpst.spec:%filter_setup
libvirt-python.spec:%{?filter_setup}
libxsmm.spec:%{?filter_setup:
libxsmm.spec:%filter_setup
mod_authnz_pam.spec:%{?filter_setup}
mod_intercept_form_submit.spec:%{?filter_setup}
mod_lookup_identity.spec:%{?filter_setup}
mod_perl.spec:- fix missing requirements, add filter_setup macro, remove 
double provides
nant.spec:%filter_setup
omniORB.spec:%{?filter_setup:
omniORB.spec:%filter_setup
opendbx.spec:%{?filter_setup:
opendbx.spec:%filter_setup
perl-AppConfig.spec:%{?filter_setup:
perl-Catalyst-Controller-FormBuilder.spec:%{?filter_setup:
perl-DateTime-Precise.spec:%{?filter_setup:
perl-HTML-TreeBuilder-XPath.spec:%{?filter_setup:
perl-HTML-TreeBuilder-XPath.spec:- update filtering for compatibility 
with older filter_setup macros
perl-IO-InSitu.spec:%filter_setup
perl-MooseX-Types-DateTimeX.spec:%filter_setup
perl-Rose-DateTime.spec:%filter_setup
perl-Rose-Object.spec:%filter_setup
perl-Socket-Netlink.spec:%{?filter_setup:
perl-Socket-Netlink-Route.spec:%{?filter_setup:
perl-Unicode-LineBreak.spec:%{?filter_setup:
perl-Wx.spec:%filter_setup
php.spec:- add filter_setup to not provides extensions as .so
php-phpiredis.spec:%{?filter_setup}
portmidi.spec:%{?filter_setup:
portmidi.spec:%filter_setup
purple-facebook.spec:%filter_setup
purple-facebook.spec:- Properly run %%filter_setup
pymilia.spec:%{?filter_setup:
pymilia.spec:%filter_setup
python3-poppler-qt5.spec:%{?filter_setup:
python3-poppler-qt5.spec:%filter_setup
python-cups.spec:%{?filter_setup:
python-cups.spec:%filter_setup
python-sane.spec:%filter_setup
python-smbc.spec:%{?filter_setup:
python-smbc.spec:%filter_setup
scribus.spec:%filter_setup
scummvm.spec:%{?filter_setup:
scummvm.spec:%filter_setup
smokeping.spec:%{?filter_setup:
smokeping.spec:%filter_setup
uuid.spec:%{?filter_setup}
vdr-femon.spec:- Filter out autoprovided libvdr-*.so.* (if 
%%filter_setup is available).
vdr-osdteletext.spec:- Filter out autoprovided libvdr-*.so.* (if 
%%filter_setup is available).
vdr-remote.spec:- Filter out autoprovided libvdr-*.so.* (if 
%%filter_setup is available).
vym.spec:%{?filter_setup:
whatsup.spec:%{?filter_setup:
whatsup.spec:%filter_setup
xapian-bindings.spec:%{?filter_setup}
uwsgi.spec:%filter_setup

~~~


If you ask why you should remove those, then the reason is that the "old 
style generators" disables the new style generators and therefore your 
package might be missing some commonly used requires/provides and is 
inconsistent with the rest of distribution.


Vít


[1] https://pagure.io/packaging-committee/pull-request/947

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue