Hi, On 8/5/24 12:57 PM, Richard W.M. Jones wrote: > On Sun, Aug 04, 2024 at 10:28:06PM +0200, Hans de Goede wrote: >> Hi All, >> >> A long time ago I packaged clonekeen, an opensource engine for playing >> the commander keen games including the shareware releases. >> >> clonekeen upstream has not been active for a while. >> >> clonekeen is written in somewhat ancient C-style and starting with >> the more stringent C syntax checks in F40 it now fails to build: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=2261036 >> https://bugzilla.redhat.com/show_bug.cgi?id=2300597 >> >> I took a quick look at fixing it, but it has some ugliness >> going on with storing integers in pointers without proper >> casts. Not impossible to fix, but I don't have time for it. > > If fixing it is beyond hope then '%global build_type_safety_c 0' is > possible (https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md). Thanks I was not aware of that option. > Of course you give other good reasons below why it might be an idea to > abandon this package ... Right, so I just checked and the commander genius fork is actually already packaged on flathub, so I believe that for users who want to play the old commander keen games natively (rather then under dosbox) getting commander genius from flathub is the best solution. Given this I have just retired clonekeen for F41+. If anyone is still interested in creating a rpm package of commander genius as a replacement my offer to review that still stands. But IMHO for end user applications like this flathub is the way to go rather then duplicating the packaging work in many distros. Regards, Hans -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue