On Sun, Aug 04, 2024 at 10:28:06PM +0200, Hans de Goede wrote: > Hi All, > > A long time ago I packaged clonekeen, an opensource engine for playing > the commander keen games including the shareware releases. > > clonekeen upstream has not been active for a while. > > clonekeen is written in somewhat ancient C-style and starting with > the more stringent C syntax checks in F40 it now fails to build: > > https://bugzilla.redhat.com/show_bug.cgi?id=2261036 > https://bugzilla.redhat.com/show_bug.cgi?id=2300597 > > I took a quick look at fixing it, but it has some ugliness > going on with storing integers in pointers without proper > casts. Not impossible to fix, but I don't have time for it. If fixing it is beyond hope then '%global build_type_safety_c 0' is possible (https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/buildflags.md). Of course you give other good reasons below why it might be an idea to abandon this package ... > If anyone is interested in taking this over, rather then letting > it get orphaned then it might be better to spend your time on > the commander genius fork of clonekeen: > > https://clonekeenplus.sourceforge.io/ > > This is an active upstream doing somewhat regular releases. > Commander Genius has the ancient C-code converter to c++ and SDL2. > Plus it has builtin support to download the shareware data for > users who don't have the gamedata from the full games. > So switching to Commander Genius as upstream will also allow > dropping the auto-downloader stuff for the shareware files. > > I think that it would be best to treat this as a package > rename and create a new commander-genius package for > Commander Genius which obsoletes + provides clonekeen. > > I would be happy to review such a new package. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue