On Thu, Aug 1, 2024 at 9:24 AM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
Well, if you have a general package that's shipped in every buildroot
for flatpak builds, you can ship your own wrapper, and I can make it
check if RPM_BUILD_ROOT is defined *and* this file exists, it would
redirect to that wrapper automatically. Or some variation of this.
We used to do something similar for MinGW, I believe, so I think it'd work.
So, basically, your proposal is that we patch the pkg-config package so that if /etc/flatpak-rpm-build exists then we set a default PKG_CONFIG_PATH that includes /app? What's the advantage over just adding /app unconditionally?
- Owen
I am rather weary about this, if the idea is to make this applicable to users as well. Let's say we have two flatpak apps which both have a public dependency of a common dependency (let's say they both contain `#include` on a header from there), but the versions are different in each. How would `/app/lib64/pkgconfig` deal with having both apps installed (granted I am not familiar with this part of flatpaks).
The more concerning part is if a random app unnecessarily exposes a dependency's .pc files, e.g. if the dependency was included via CMake's `add_subdirectory` and the installation of the dependency was not guarded by a `<PROJECT>_INSTALL` option. Then the user might get some surprises when they try to build something locally, particularly since the order of preference between `/usr/lib64` and `/app/lib64` is unclear.
If it's limited to building within the spec file, then it is more understandable, but at that point shouldn't it still be handled within `flatpkg-rpm-macros`?
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
