On Thu, Aug 1, 2024 at 9:24 AM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
On Thu, Aug 1, 2024 at 9:13 AM Owen Taylor <otaylor@xxxxxxxxxx> wrote:
>
> Hi Neal -
>
> Daniel's original suggestion here (make pkg-config always look in /app too) actually seems fine to me and simple, and I don't see any downsides. But certainly flatpak-rpm-macros doesn't *just* modify RPM macros, it currently also:
>
> - Changes the installation prefix for Python by dropping a distutils.cfg
> - Adds a configuration file for Maven to change install and search paths
>
> So it's sort of a more general "flatpak-rpm-build" environment. If there was a way to set PKG_CONFIG_PATH globally for the buildroot upon install of the package, that could work too. (Or, yes, we could set FLATPAK_RPM_BUILD and make pkg-config react to that). But how would you do that? mock --chroot doesn't seem to pick things up from /etc/profile.d or /etc/environment.
>
> The only way I can think of doing it would be by configuring rpm.env.* for the Flatpak build tags in Koji, and losing the property that you can "just" drop flatpak-rpm-macros in to get the Flatpak RPM build environment. Do you see any other way?
>
Well, if you have a general package that's shipped in every buildroot
for flatpak builds, you can ship your own wrapper, and I can make it
check if RPM_BUILD_ROOT is defined *and* this file exists, it would
redirect to that wrapper automatically. Or some variation of this.
We used to do something similar for MinGW, I believe, so I think it'd work.
So, basically, your proposal is that we patch the pkg-config package so that if /etc/flatpak-rpm-build exists then we set a default PKG_CONFIG_PATH that includes /app? What's the advantage over just adding /app unconditionally?
- Owen
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
