On Mon, Jul 22, 2024 at 11:32:03PM +0000, Zbigniew Jędrzejewski-Szmek wrote:
> On Tue, Jul 23, 2024 at 01:19:27AM +0200, Miro Hrončok wrote:
> > On 23. 07. 24 1:07, Zbigniew Jędrzejewski-Szmek wrote:
> > > I noticed the following when comparing packages after the rebuild:
> > >
> > > │ │ │ -{"type":"rpm","name":"guile22","version":"2.2.7-12.fc41","architecture":"x86_64","osCpe":"cpe:/o:fedoraproject:fedora:40"}
> > > │ │ │ +{"type":"rpm","name":"guile22","version":"2.2.7-14.fc41","architecture":"x86_64","osCpe":"cpe:/o:fedoraproject:fedora:40"}
> > >
> > > It seems the info in os-release hasn't been updated so the
> > > package notes embedded in the binaries are off.
> >
> >
> > package-notes has:
> >
> > %build
> > sed "s|@OSCPE@|$(cat /usr/lib/system-release-cpe)|" %{SOURCE0}
> > >redhat-package-notes
> >
> > But the last build before the mass rebuild happened on Fedora 40.
> >
> > To prevent this situation in the future, package-notes needs to be rebuilt
> > right after branching.
>
> You are right, that's really a bug in package-notes.
> I think we could replace the static string with a read of
> /usr/lib/system-release-cpe.
I forgot that the latest implementation uses the linker spec file
"language" to insert the note. After banging my head against the screen
and keyboard for an hour, I couldn't figure out any way to make this
happen. It seems that we can only substitute variables, but not read
an arbitrary file.
The only solution I can think of is to set $RPM_OS_RELEASE_CPE along
with other variables in the rpm setup, and use that via getenv in
/usr/lib/rpm/redhat/redhat-package-notes.
Zbyszek
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
