Re: Screen brightness keys not working

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

On Thu, 18 Jul 2024 at 11:28, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi,

On 7/16/24 5:59 PM, Iñaki Ucar wrote:
>
>
> On Tue, 16 Jul 2024 at 12:29, Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote:
>
>     Hi,
>
>     On 7/15/24 9:50 PM, Iñaki Ucar wrote:
>     > It's the kernel. Going back to 6.9.6 fixes the issue...
>
>     Ok, that is a good first step in debugging this.
>
>     Can you run evtest with the working kernel and then check which
>     event node is generating key-presses for the brightness keys,
>     that should help narrow it down further.
>
>     Likely candidates are: "LG WMI hotkeys",
>     "AT translated set 2 keyboard", "Video Bus".
>
>
> In "Video Bus", there are KEY_BRIGHTNESSDOWN and KEY_BRIGHTNESSUP that are triggered.

Ok, then this likely is not an issue with the lg-laptop driver but rather with
the ACPI subsystem.

Likely culprit commits which are new in 6.9.7 are:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi?h=v6.9.7&id=2b2b0ac1533d790690d6d28899f01a2924d54d4d
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi?h=v6.9.7&id=9750135f2f326879889ed60ccd68b96572dfa6ee


Or maybe:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/acpi?h=v6.9.7&id=e21a4c9129c72fa54dd00f5ebf71219b41d43c04

But I suspect it is one of the above 2.

I have started a 6.9.9 test-build with those 2 patches reverted:

https://koji.fedoraproject.org/koji/taskinfo?taskID=120674294

Good catch! I confirm that the build above does not have the issues I was experiencing.

Iñaki
 
this will take a couple of hours to finish building. Here are some generic instructions
for installing a kernel from koji (the Fedora build system):

https://fedorapeople.org/~jwrdegoede/kernel-test-instructions.txt

Please give this kernel build a try when it is done building and then
we will see from there.

Regards,

Hans




>     But if none of those 3 reports brightness key presses, please
>     try all available /dev/input/event# nodes and please report back
>     here the name(e.g. "LG WMI hotkeys") of the /dev/input/event# node
>     which is reporting the brightness key presses.
>
>     Also which kernel version is the first broken kernel version
>     for you ?
>
>
> 6.9.7 to 6.9.9 are broken. I also noticed issues with /sys/devices/platform/lg-laptop/battery_care_limit, that reports 0 and cannot be set with those kernels.
>
> There are commits in the lg-laptop.c file in the 6.10 series that I hope solve these issues, see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/platform/x86/lg-laptop.c?id=v6.10&id2=v6.9 <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/drivers/platform/x86/lg-laptop.c?id=v6.10&id2=v6.9>
>
> Iñaki
>  
>
>
>
>     Regards,
>
>     Hans
>
>
>
>
>
>     >
>     > Iñaki
>     >
>     > On Mon, 15 Jul 2024 at 21:34, Iñaki Ucar <iucar@xxxxxxxxxxxxxxxxx <mailto:iucar@xxxxxxxxxxxxxxxxx> <mailto:iucar@xxxxxxxxxxxxxxxxx <mailto:iucar@xxxxxxxxxxxxxxxxx>>> wrote:
>     >
>     >
>     >
>     >     On Mon, 15 Jul 2024 at 18:53, Jonathan Wright via devel <devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx> <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx>>> wrote:
>     >
>     >         Are you running KDE with HDR enabled by chance?  That will make the keys non-functional.
>     >
>     >
>     >     No, I don't think so. I don't see any HDR option anyways.
>     >
>     >     Iñaki
>     >      
>     >
>     >
>     >         On Mon, Jul 15, 2024 at 3:52 AM Samuel Sieb <samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>> wrote:
>     >
>     >             On 7/15/24 1:47 AM, Iñaki Ucar wrote:
>     >             > On Mon, 15 Jul 2024 at 10:34, Samuel Sieb <samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>
>     >             > <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>>> wrote:
>     >             >
>     >             >     On 7/15/24 1:23 AM, Iñaki Ucar wrote:
>     >             >      >
>     >             >      >
>     >             >      > On Mon, 15 Jul 2024 at 09:56, Samuel Sieb <samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>
>     >             >     <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>>
>     >             >      > <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx> <mailto:samuel@xxxxxxxx <mailto:samuel@xxxxxxxx>>>>> wrote:
>     >             >      >     You will need to find out what the keys trigger.
>     >             >      >     Do you see any messages in the journal when you press the keys?
>     >             >      >
>     >             >      >
>     >             >      > Nothing in the journal.
>     >             >      >
>     >             >      >     Install "evtest" and try watching various sources to see if
>     >             >     you get a
>     >             >      >     reaction when pressing the keys.
>     >             >      >
>     >             >      >
>     >             >      > Nothing either. I tried monitoring the keyboard as well as the
>     >             >     event fd
>     >             >      > called "LG WMI hotkeys", and those keys trigger nothing. :( Does
>     >             >     this
>     >             >      > mean that it's a kernel issue?
>     >             >
>     >             >     Probably.  Do you have the "lg-laptop" kernel module loaded?
>     >             >
>     >             > I do:
>     >             > $ lsmod | grep lg
>     >             > lg_laptop              32768  0
>     >             > sparse_keymap          12288  1 lg_laptop
>     >             > i2c_algo_bit           20480  2 xe,i915
>     >             > wmi                    36864  3 video,lg_laptop,wmi_bmof
>     >
>     >             I suggest you contact the mailing list at:
>     >             platform-driver-x86@xxxxxxxxxxxxxxx <mailto:platform-driver-x86@xxxxxxxxxxxxxxx> <mailto:platform-driver-x86@xxxxxxxxxxxxxxx <mailto:platform-driver-x86@xxxxxxxxxxxxxxx>>
>     >
>     >             --
>     >             _______________________________________________
>     >             devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx> <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >             To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx> <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >             Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ <https://docs.fedoraproject.org/en-US/project/code-of-conduct/> <https://docs.fedoraproject.org/en-US/project/code-of-conduct/ <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>>
>     >             List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines <https://fedoraproject.org/wiki/Mailing_list_guidelines> <https://fedoraproject.org/wiki/Mailing_list_guidelines <https://fedoraproject.org/wiki/Mailing_list_guidelines>>
>     >             List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx> <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >             Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue <https://pagure.io/fedora-infrastructure/new_issue> <https://pagure.io/fedora-infrastructure/new_issue <https://pagure.io/fedora-infrastructure/new_issue>>
>     >
>     >
>     >
>     >         --
>     >         Jonathan Wright
>     >         AlmaLinux Foundation
>     >         Mattermost: chat <https://chat.almalinux.org/almalinux/messages/@jonathan <https://chat.almalinux.org/almalinux/messages/@jonathan>>
>     >         --
>     >         _______________________________________________
>     >         devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx> <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >         To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx> <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx <mailto:devel-leave@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >         Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ <https://docs.fedoraproject.org/en-US/project/code-of-conduct/> <https://docs.fedoraproject.org/en-US/project/code-of-conduct/ <https://docs.fedoraproject.org/en-US/project/code-of-conduct/>>
>     >         List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines <https://fedoraproject.org/wiki/Mailing_list_guidelines> <https://fedoraproject.org/wiki/Mailing_list_guidelines <https://fedoraproject.org/wiki/Mailing_list_guidelines>>
>     >         List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx> <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx <https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx>>
>     >         Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue <https://pagure.io/fedora-infrastructure/new_issue> <https://pagure.io/fedora-infrastructure/new_issue <https://pagure.io/fedora-infrastructure/new_issue>>
>     >
>     >
>     >
>     >     --
>     >     Iñaki Úcar
>     >
>     >
>     >
>     > --
>     > Iñaki Úcar
>     >
>
>
>
> --
> Iñaki Úcar



--
Iñaki Úcar
-- 
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux