Updated my changes to be as minimal as possible:
https://github.com/italia/cie-middleware-linux/commit/def0b8bec398e4369d6eaa93d4b5143a67989330
This already allows building the Java code with a single command: `mvn compile / package / install` depending on the desired result. This is still very non-standard as far as Java projects go, and if they are serious about SW quality, I would go ahead and open more pull requests.
For the document, I would add the following bullet:
...
2. Please switch to using Maven for building the Java code. This
makes it much clearer which Java dependencies the project uses and
makes it possible to easily build the Java code from the command
line. [mention my commit]. Gradle is not a preferred build system
in Fedora due to various problems with its distribution.
...
I am open to providing more guidance about "fixing" the Java side
if I know what their requirements are.
Marián Konček wrote:
[...]Note that my commits are dirty and I am not proposing them as changes, they show that it is possible to adopt Maven.
So according to this, what would you recommend me to change in the point n.1 of my draft letter
https://germano.fedorapeople.org/canc/cie_middleware.md
=====
1. please switch to CMake build system completely: some parts of the software need to be built through Eclipse, I.E. cie-pkcs11. CMake should be the only build system in the project. CMake will also enable CIE Middleware being built for all Linux distributions, Mac OS, Windows;
=====
?
-- Marián Konček
-- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
