Hi, I am a member of Fedora Java package maintainers.
I see several problems with this project:
1. *.jar, *.a, *.o files not only do not belong into Fedora sources,
they should not even be in *any* GitHub repository unless they are used
for testing. Binary components are not sources.
2. Requiring graphical Eclipse to build some Java code is a heavy
overkill, you should instead add a standard Java build system like Maven
or add CMake targets to build Java code using standard tools like
`javac` and `jar`.
3. generated files like *.d, *.mk should also not be in a source
repository, unless there is a good reason for them.
4. You will do the others a great service if you use the English
language in GitHub commits and READMEs. Open-source software is not
there for you but for the whole world.
5. (minor) The project is missing a README information what it actually
is about. All I could read about is that it is "some middleware for Linux".
You should really take a look at other more standard projects on GitHub,
how they handle builds and library dependencies.
On 18. 7. 2024 16:42, Germano Massullo wrote:
Hello, I discussed the feasibility of packaging
https://github.com/italia/cie-middleware-linux
in Fedora devel Matrix channel with Cristian Le and xvitaly. With the
help of Cristian Le I wrote the following [1] draft that will be used
to open an upstream ticket to request various improvements to make it
possible to include the software in the Fedora repository.
We ended up needing the comment from Java package maintainers, if they
see any other no-go. I am in particular concerned about
https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_pre_built_dependencies
Thank you
[1]: https://germano.fedorapeople.org/canc/cie_middleware.md
--
Marián Konček
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
