On Tue, 2024-07-16 at 09:19 -0400, Stephen Gallagher wrote: > On Mon, Jul 15, 2024 at 4:06 PM Zbigniew Jędrzejewski-Szmek > <zbyszek@xxxxxxxxx> wrote: > > > > On Mon, Jul 15, 2024 at 08:55:03AM -0400, Stephen Gallagher wrote: > > > This seems like overkill. Wouldn't the simplest valid installability > > > test just be to test whether each subpackage *individually* could be > > > installed? > > > > That's a really nice idea. > > > > > If we have 20 subpackages, just launch 20 separate minimal containers > > > and see if `dnf install subpackageN` succeeds. Then it doesn't matter > > > if there are conflicts; we know that at least installing that package > > > directly will work. (Dependency resolution may pull in other > > > subpackages of course, which is proving that it works properly.) > > > > I'm not sure if we actually want a container. Because if it's a container, > > then we need _some_ packages inside. But that creates a problem for > > some packages like cannot be just installed, but need to be swapped > > with other packages. (systemd-standalone-*, coreutils-single, etc.) > > I think it'd be more reliable to do something like > > dnf install --enablerepo=/path/to/repo/with/updates --sysroot=/var/tmp/inst-package1 /path/to/repo/with/updates/package1.rpm > > dnf install --enablerepo=/path/to/repo/with/updates --sysroot=/var/tmp/inst-package1 /path/to/repo/with/updates/package2.rpm > > ... > > > > And to make this work reliably, the invocation of dnf should be > > wrapped in 'bwrap' to set up /dev, /proc for the invocation. > > > > This should be quick and more reliable than the current tests, > > even with no config. > > > > Sure, I oversimplified by saying "container", but I agree with your > suggestion. That seems both simple and effective. I predict it would turn up some interesting failures on packages which assumed a more 'realistic' environment. I'm not entirely sure there is a silver bullet for a test like this; what it needs is dedicated and focused attention. -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@xxxxxxxxxxxxx https://www.happyassassin.net -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
