On Thu, 16 May 2024 10:52:29 +0000
Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> wrote:
> On Thu, May 16, 2024 at 11:09:01AM +0200, Fabio Valentini wrote:
> > This looks like you're putting the resolver between a rock and a
> > hard place. :thinking:
> > I don't think I've ever seen packages being *removed* when
> > installing BuildRequires on top of the minimal buildroot ...
> >
> > Would it be possible to adapt the packages so that add-determinism
> > and add-determinism-nopython are parallel-installable, and have the
> > macro fall back to the add-determinism-nopython executable if the
> > add-determinism executable is not available?
> > That way BuildRequires are additive and wouldn't force package
> > removal from the buildroot, and the rich dependency could be
> > simpler - i.e. `Requires: (add-determinism if python3-libs)`,
> > without Suggests or else branch.
>
> Yeah, I think this is the most reasonable approach.
> I'll push a build that does this shortly.
>
> (I tried to test this locally with mock, with the additional packages
> in a local repo. When I install everything in one go, things work as
> expected. Why I try to check the original issue, and install packages
> piecemeal, mock downgrades packages to fall back to the koji version
> without dependencies, instead of installing the additional deps. In
> koji, it'll only have one version of the package available, so
> hopefully it'll pick addition instead of removals.)
Not sure how this is supposed to work: add-determinism-nopython seems
to install %{_bindir}/add-determinism.nopython but the macro only seems
to look for %{_bindir}/add-determinism, resulting in this when only
add-determinism-nopython is installed:
(https://koji.fedoraproject.org/koji/taskinfo?taskID=117791675)
+ /usr/bin/add-determinism --brp -j48 /builddir/build/BUILDROOT/perl-Finance-Quote-1.6200-1.fc41.noarch
/var/tmp/rpm-tmp.hdLEuR: line 89: /usr/bin/add-determinism: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.hdLEuR (%install)
The intent seems to be that the minimal version checks for existence of
the full version and re-execs it if found. So it seems to me that the
minimal version should be installed as %{_bindir}/add-determinism and
the full version should be called %{_bindir}/add-determinism.withpython
or something. Or maybe just tweak the rpm macro to define
%__brp_add_determinism as %{_bindir}/add-determinism.nopython.
Regards, Paul.
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
