On Sun, Apr 07, 2024 at 05:47:57PM +0200, Miro Hrončok wrote: > On 07. 04. 24 17:15, Zbigniew Jędrzejewski-Szmek wrote: > > Hi everyone, > > > > I'm revisting the topic of rpmautospec because I was doing some work > > on various packages, and it's annoying that some packages are using > > rpmautospec and others are not. > > > > All my packages have been converted, so in day-to-day work, I don't > > even think about %changelog. When working with other packages, I'll > > forget to update the Relase and/or %changelog. Today I was rebasing > > some pull requests in pagure, and the _only_ conflicts that I had were > > about Release and %changelog. > > > > I think it's time to switch to rpmautospec completely. > > Thus, the proposal: > > - new packages MUST use rpmautospec > > - packagers SHOULD convert their packages > > - provenpackagers MAY convert existing packages > > (e.g. when they want to push some fix or separately from other > > work) > > - people submitting pull requests against src.fp.o MAY also > > include a conversion in the pull request and packagers SHOULD > > merge it. > > I have some packages where the tooling isn't ready yet for %autorelease, so > I put them on hold. > > I also have some packages with pre-release info still in the Release filed > and moving it to Version with ~ (to use %autorelease) would make the package > downgrade, so I am waiting for a next upstream release to do that. > > I think it's to early to force this. In the other part of the thread, an opt-out via 'norpmautospec' is proposed. So I think we'd use this in such cases too. > > (FTR, 'rpmautospec convert' does the conversion, incl. the commit > > to dist-git. Manual conversion should not be used.) > > Note that it produces incorrect results if the Release value is not > numerical (or if it is a greater number than count of the commits since last > bump). It will happily convert release 0.1 to 3, 29.20130501hg26242d0aa7b8 > to 30 or even release 500 to 10. > > I converted all of my packages with it and in some cases I had to manually > fix the results. > > E.g.: > > https://src.fedoraproject.org/rpms/printrun/pull-request/8 > https://src.fedoraproject.org/rpms/pypy3.10/pull-request/15#comment-179619 > https://src.fedoraproject.org/rpms/poly2tri/pull-request/2 + fixup commit on > top https://src.fedoraproject.org/rpms/poly2tri/c/053f90 That's unfortunate :(. I'll take a look if the code can be improved. Zbyszek -- _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
