Re: google-re2 pacakge update and facebook vs google python bindings ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 24, 2024 at 11:49 AM Michael J Gruber <mjg@xxxxxxxxxxxxxxxxx> wrote:
>
> Am Sa., 24. Feb. 2024 um 03:37 Uhr schrieb Adam Williamson
> <adamwill@xxxxxxxxxxxxxxxxx>:
> >
> > On Fri, 2024-02-23 at 13:36 -0500, Paul Wouters wrote:
> > > On Wed, 7 Feb 2024, Ben Beasley wrote:
> > >
> > > > Subject: Re: google-re2 pacakge update and facebook vs google python bindings
> > >
> > > I haven't heard back from any of the maintainers.
> > >
> > > I've created a PR to upgrade re2-2022-06-01 to re2-2024-02-01 as the
> > > first step towards getting python-google-re2 working.
> > >
> > > https://src.fedoraproject.org/rpms/re2/pull-request/6
> >
> > You now seem to have just built re2 for Rawhide without any of the
> > deps:
> >
> > https://bodhi.fedoraproject.org/updates/FEDORA-2024-daa3669e4d
> >
> > that's not how you're supposed to do things, these days. You should
> > build re2 on a side tag and then get all the deps rebuilt on the same
> > side tag, then create a combined update. The update failed tests
> > because of this.
> >
> > The best thing to do at this point would be to create a side tag, bump
> > re2 and do a new build on the side tag, then ask maintainers of
> > dependencies and/or provenpackagers to rebuild the dependencies on the
> > side tag.
> > --
>
> Also, the commit introduced a switch to autochangelog, which should be
> the maintainer's decision, and is best done in a separate commit
> before the bump. Besides, the changelog file was not committed to
> dist-git. Did this just erase all changelog history from the rpm?

Yes, this was done incorrectly (both the uncoordinated non-side-tag
build *and* the conversion to rpmautospec) ... I would suggest
somebody revert the two commits in git for now.

Fabio
--
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux