Re: Announced pkgconf soname change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 23, 2023 at 6:43 PM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
>
> On Thu, Feb 23, 2023 at 8:02 AM Neal Gompa <ngompa13@xxxxxxxxx> wrote:
> >
> > On Thu, Feb 23, 2023 at 7:55 AM Petr Pisar <ppisar@xxxxxxxxxx> wrote:
> > >
> > > pkgconf-1.9.4-1.fc39, comparing to 1.8.0-6.fc39, changed a soname without
> > > a notice on this list. Affected packages:
> > >
> > > # dnf -q --repoid f39-build repoquery --whatrequires 'libpkgconf.so.3()(64bit)' --source | sort -u
> > > build2-0.15.0-1.fc37~bootstrap.src.rpm
> > > perl-PkgConfig-LibPkgConf-0.11-11.fc38.src.rpm
> > >
> > > It also broke API:
> > >
> > > LibPkgConf.xs:246:23: error: too few arguments to function 'pkgconf_pkg_new_from_file'
> > >   246 |       RETVAL = PTR2IV(pkgconf_pkg_new_from_file(&self->client, filename, fp));
> > >       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > From an upstream changelog:
> > >
> > > * pkgconf 1.9.0 is the first testing release in the pkgconf 2.0 development
> > >   series.  While it is believed to be suitable for production, there may be
> > >   bugs due to the overall redesign of the solver and other initiatives.
> > >   Additionally, a future release of pkgconf plans will have additional ABI
> > >   breaks for the libpkgconf library before the pkgconf 2.0 release is cut.
> > >
> >
> > My bad, I missed that this package doesn't have the soversion tracked.
> > I'll update the packaging for that going forward.
> >
>
> I've updated the packaging to track this going forward:
> https://src.fedoraproject.org/rpms/pkgconf/c/930106a9359d866a6591b27e797fd396b2013b08?branch=rawhide

Is it possible that pkgconf 1.9.4 changed some string quoting
behaviour between 1.9.3 and 1.9.4?
The upstream changelog [0] doesn't mention any related changes as far
as I can see, but the test suite of the "pkg-config" Rust crate
started failing because escaped strings returned by pkg-config now
look slightly differently:

  left: `Some(Some("\"escaped string\\' literal\""))`, // the actual value
 right: `Some(Some("\"escaped string' literal\""))`', // the expected value

The additional escaping of the single-quote with pkgconfig 1.9.4
actually seems to be the more correct behaviour?
Because in the old "expected" string, the single quote is not escaped
at all? Not sure. Please advise :)

Fabio

[0]: https://github.com/pkgconf/pkgconf/blob/master/NEWS
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux