I personally very much prefer to keep stale conditionals out of the spec files I work on, but I also concur that it is reasonable to want to leave this to maintainer discretion. On Thu, Jan 19, 2023, at 11:14 AM, Robbie Harwood wrote: > Michal Schorm <mschorm@xxxxxxxxxx> writes: > >> On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood <rharwood@xxxxxxxxxx> wrote: >>>> Would you see a value in e.g. some kind of a robot reminding >>>> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI >>>> check) >>> >>> Please don't. >> >> Would you mind expanding your answer a bit, please? >> I'd like to learn why people would (not) like such a check or reminder. > > First, there's no benefit to removal. Nothing is harmed by having > something that always evaluates like `#if 0` unless it seriously impacts > readability. Spec file "hygiene" is not inherently good (or inherently > bad) beyond that. > > A check or reminder is another nag notification. We don't need more of > those, especially for low-priority items. > > And to head something off: it's not better when someone provenpackagers > the change in. Then there's an unnecessary revbump, and the > maintainers's checkouts desync from the main repo (merge > conflicts/rebase). > > Be well, > --Robbie > > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > > Attachments: > * signature.asc _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
