Michal Schorm <mschorm@xxxxxxxxxx> writes: > While playing around with Sourcegraph, which indexed all Fedora > package repositories, I was able to craft a query listing all '%if' > conditionals referencing Fedora releases that reached EOL. > > Do you agree it would be safe to remove such conditionals and the code > they hold ? Yes, at maintainer discretion. > Do you agree that removing obsolete code such as this brings value to > the package codebase ? No - it's annoying code churn that usually serves no purpose. If maintainers want them gone, generally they'll remove them. > Would you see a value in e.g. some kind of a robot reminding > maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI > check) Please don't. Be well, --Robbie
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue