On Thu, 19 Jan 2023 at 10:52, Michal Schorm <mschorm@xxxxxxxxxx> wrote: > > Hello, > While playing around with Sourcegraph, which indexed all Fedora > package repositories, I was able to craft a query listing all '%if' > conditionals referencing Fedora releases that reached EOL. > > https://sourcegraph.com/search?q=context:global+repo:%5Esrc%5C.fedoraproject%5C.org/rpms+file:.spec+%28%25if.*%25%7B%5C%3Ffedora%7D.*%5B%3C%3D%3E%5D.*%29%28%5B12%5D%5B0-9%5D%7C%5B3%5D%5B012345%5D.*%29+count:all&patternType=regexp&case=yes&sm=0&groupBy=group > > I don't believe such conditions have any value and I think we can > remove them right away. > I think the removal shouldn't affect neither Fedora nor derived > operating systems. > > If removed, they will be preserved in the git history anyway, for > anyone seeking historical code. > > In some cases the conditionals hold patches that could be removed with them: > > https://sourcegraph.com/search?q=context:global+repo:%5Esrc%5C.fedoraproject%5C.org/rpms+file:.spec+%28%25if.*%25%7B%5C%3Ffedora%7D.*%5B%3C%5D.*%29%28%5B12%5D%5B0-9%5D%7C%5B3%5D%5B0123456%5D.*%5Cn%2B%29%28.*%5Cn%3F%29%28%25patch.*%29+count:all&patternType=regexp&case=yes&sm=0&groupBy=group > > -- > > Do you agree it would be safe to remove such conditionals and the code > they hold ? For the packages I (co)maintain, I see no value in keeping it. Maybe somebody has a reason for keeping it in their specs, but I can't see any value in it. > Do you agree that removing obsolete code such as this brings value to > the package codebase ? Yes, it makes it easier for others to open the spec file and quickly understand what it's doing. > Would you see a value in e.g. some kind of a robot reminding > maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI > check) I don't think that's worth the effort/noise. _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
