On Thu, Jan 12, 2023 at 06:46:17PM -0500, Siddhesh Poyarekar wrote: > On Thu, Jan 12, 2023 at 6:38 PM Jakub Jelinek <jakub@xxxxxxxxxx> wrote: > > But at least you don't need both -U_FORTIFY_SOURCE and > > -Wp,-U_FORTIFY_SOURCE, one of them is enough. And the latter I think > > better gets through libtool and other tools; especially if you put it > > into a single -Wp, option together with the redefinition... > > Uhmm, I could have sworn that I had needed -Wp,-U... for the -Wp-D... > and -U for the -D when I was fixing the test builds but you're right, > simply -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=3 appears to work > for both -D_FORTIFY_SOURCE=2 as well as -Wp,-D_FORTIFY_SOURCE=2. I'll > test this some more and post a PR for redhat-rpm-config. > Thanks, Sid and Jakub, for digging in and identifying the issue! Looking forward to being able to use ccache for my local Rawhide builds again. Glad this will end up making the change less brittle too. Best regards, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
