Re: F38 proposal: Add _FORTIFY_SOURCE=3 to distribution build flags (System-Wide Change proposal)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 11, 2023 at 06:44:22PM -0500, Siddhesh Poyarekar wrote:
> On Wed, Jan 11, 2023 at 4:43 PM Siddhesh Poyarekar <siddhesh@xxxxxxxxxx> wrote:
> > On Wed, Jan 11, 2023 at 4:37 PM Siddhesh Poyarekar <siddhesh@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Jan 11, 2023 at 3:05 PM Michel Alexandre Salim
> > > <salimma@xxxxxxxxxxxxxxxxx> wrote:
> > > > Just `mock -r fedora-rawhide-x86_64 ./*.src.rpm`
> > > >
> > > > I have these additional knobs in ~/.config/mock.cfg:
> > > >
> > > >
> > > > config_opts['plugin_conf']['ccache_enable'] = True
> > > > config_opts['plugin_conf']['ccache_opts']['max_cache_size'] = '10G'
> > > >
> > > > # False: build from Koji, e.g. to grab packages just put into Rawhide
> > > > # config_opts['mirrored'] = False
> > > >
> > >
> > > OK I see the warning now.  Let me dig deeper.
> >
> > So if you want the quick answer to unblock you, it is ccache; I
> > disabled it and the warning went away.  That should help you get your
> > -Werror going.  I'll look closer at why that's happening.
> 
> I've filed a ccache bug.  It looks like ccache is moving the compiler
> arguments around, causing one of the -U_FORTIFY_SOURCE to the end.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2160275

Why we do have those -U_FORTIFY_SOURCE and -Wp,-U_FORTIFY_SOURCE options
in there at all?  Previously we just had -Wp,-D_FORTIFY_SOURCE=2
and I think just changing it to -Wp,-D_FORTIFY_SOURCE=3 is more than enough.
If you think some programs are adding -D_FORTIFY_SOURCE=2 to their *FLAGS
make vars etc., then perhaps -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3
But having both -U_FORTIFY_SOURCE and -Wp,-U_FORTIFY_SOURCE seems completely
pointless to me.

	Jakub
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux