Re: Bad paths in *.pc (pkgconf) files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 16, 2022 at 12:14:21PM +0100, Kalev Lember wrote:
> On Wed, Nov 16, 2022 at 11:35 AM Richard W.M. Jones <rjones@xxxxxxxxxx> wrote:
> 
>     David (CC'd) is working on the Fedora RISC-V port and he noticed that
>     some *.pc files in Fedora contain incorrect paths.  For example[1]:
> 
>       $ pkgconf --libs libcares
>       -L/usr/usr/lib64 -lcares
> 
>       $ pkgconf --libs libasyncns
>       -L/usr/lib -lasyncns
> 
>     On non-riscv64 this happens to work because the default search path
>     includes the right directory anyway (eg. /usr/lib64).
> 
>     On riscv64 this causes build failures since meson seems to go off and
>     search for the *.so files and then tries to construct an absolute path
>     to them (I'm not sure if this isn't a bug in meson TBH).  For example:
> 
>       http://fedora.riscv.rocks/koji/taskinfo?taskID=1305782
> 
>     This problem appears to be widespread.  I scanned just the *-devel
>     packages that I happen to have installed, results below.  Not sure how
>     to scan all *-devel packages in Fedora.
> 
>     What should we do here?  Is it worth having an RPM build step that
>     checks for this problem?
> 
> 
> Maybe it would make sense to have a brp check for that, so that the builds
> error out with invalid paths? Similar to e.g. how /usr/lib/rpm/check-rpaths is
> hooked into %__os_install_post in /usr/lib/rpm/redhat/macros

Yes this is exactly what I was thinking too.  I filed a bug to track
the work:

https://bugzilla.redhat.com/show_bug.cgi?id=2143244

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux