Sandro kirjoitti 24.8.2022 klo 23.50:
Yes, after I talked to him he became aware of the dependency between the
two packages and adopted flare as well.
AFAIK, both packages have been updated to the latest upstream release
now and built successfully. They should find their way into the
different repos, soon.
Great!
However, one part of the cause of that problem is the trailing dot in
the end of '%cmake' [2]. It would be good to remove that. Since you are
interested in starting with package maintenance, that could be a good
first pull request for you.
I'll do that. I'm still in the process of getting acquainted. I tried to
fork flare and flare-engine earlier, but wasn't able to. Seems like it
was a temporary issue. Just tried again and it worked.
Anonymous forking in src.fedoraproject.org is a bit tricky to setup and
use, great to hear that you got it working.
Building flare-engine also prints out another (non-fatal) error, you
could also correct that in a pull request, just for practice:
error: %changelog not in descending chronological order
I saw that when linting. Wasn't sure how to handle that. The offending
changelog entry has the right date according to git blame. The releases
are in the right order. Probably just adjust the date to when that
release actually happened and silence rpmlint...
It looks like a commit was queuing in a pull request for a long time,
then merged after other things had happened in rawhide. Probably a more
correct Git date to use in %changelog would be the commit date instead
of author date:
$ git log --pretty=fuller -n 1 fffbc90b
commit fffbc90bcf7a79f918d6ee7f34dfdc43042967c6
Author: Justin Jacobs <jajdorkster@xxxxxxxxx>
AuthorDate: Tue Oct 12 18:31:17 2021 -0400
Commit: Erik Schilling <git@xxxxxxxx>
CommitDate: Tue Feb 1 19:42:45 2022 +0100
Update to 1.12 and fix font symlinks
The date when the release happened is good, too.
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
