On Wed, 2022-08-24 at 16:58 +0200, Alexander Sosedkin wrote:
>
> Reverted in crypto-policies-20220824-2.git2187e9c.fc38,
> sorry for the premature jump scare.
openQA caught an interesting consequence of the change while it was
live: it makes PackageKit start crashing. The journal shows these
errors:
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-13-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-14-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-15-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-16-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-17-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-18-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-19-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-20-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-21-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-22-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-23-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-24-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-25-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: failed to parse public key for /etc/pki/rpm-gpg/RPM-GPG-KEY-fedora-26-secondary
Aug 24 03:50:39 localhost.localdomain packagekitd[1397]: (null)
and then PackageKit crashes:
Aug 24 03:50:41 localhost.localdomain kernel: show_signal_msg: 93 callbacks suppressed
Aug 24 03:50:41 localhost.localdomain kernel: PK-Backend[1582]: segfault at cf79c705 ip 00007f670b981933 sp 00007f66fbcd4ca0 error 4 in libglib-2.0.so.0.7302.0[7f670b92a000+92000]
Aug 24 03:50:41 localhost.localdomain kernel: Code: 84 00 00 00 00 00 90 41 57 49 89 d7 41 56 41 55 41 54 55 48 89 f5 53 89 fb 48 83 ec 08 48 8b 56 08 48 85 d2 0f 84 cb 01 00 00 <48> 8b 0a 48 89 f0 48 89 d5 48 89 4e 08 48 85 c9 0f 84 a9 01 00 00
so, from this we learn that the change would prevent PackageKit (and
presumably other tools) from being able to read old Fedora signing
keys; I'm not sure if that's a problem or not. We also learn that
PackageKit appears to have a bug when it can't parse *multiple* key
files, it needs to handle its error variables better. I guess I'll file
a bug on PK for that.
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha
https://www.happyassassin.net
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
