There is no right or wrong, I just saw this as unusual.
I see this is a complex package and you went through some decision
process when deciding on this.
I would still do something about the manually expanded %mvn_install macro.
Is it a big problem to have the java artifacts placed into a
"anrlt4-project" directory?
If nothing else, maybe you could rpm --eval %%mvn_install | sed '-n
%{name}' or something like that in the %prep section?
On 26. 7. 2022 11:33, Fabio Valentini wrote:
On Tue, Jul 26, 2022 at 11:08 AM Marián Konček <mkoncek@xxxxxxxxxx> wrote:
I used a wrong mailing list, I meant to send it here.
I still see this approach as wrong. You can change the archfulness of
the main package. You can add a -java subpackage which is noarch and
provides the main package name for example. In the .spec I see you
manually invoke expanded %mvn_install macro.
"antlr4-project" is what "antlr4" should be in my opinion.
If you want to blame somebody for this, then blame me.
It was my suggestion to do it this way during package review:
https://bugzilla.redhat.com/show_bug.cgi?id=1795470#c2
However, I still think it was the right decision to do it this way.
And I don't think your alternative approach would work, because this
statement from your suggested alternative approach is wrong:
You can change the archfulness of the main package.
The main / source package needs to be "archful", because noarch source
packages cannot have non-noarch subpackages.
I just checked, and subpackages inherit the "BuildArch" tag from the
source package.
So you can override subpackages to make them noarch (archful package
with noarch subpackages), but *not* the other way round.
Fabio
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
--
Marián Konček
_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
