Re: Fix aarch64 build on embree

[Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx>]

On 2022-06-29 02:05, Petr Pisar wrote:

> V Tue, Jun 28, 2022 at 07:08:31PM -0700, Luya Tshimbalanga napsal(a):
> > Hello team,
> >
> > What is the way to disable `-mss2 for aarch64 build in embree?
> >
> > Spec file:
> > https://src.fedoraproject.org/rpms/embree/blob/rawhide/f/embree.spec
> >
> > Scratch build result:
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=88867571
> >
> >       
> Are you sure your scratch build corresponds to the linked spec file?
>
> The spec file reads:
>
>     %ifarch x86_64
>             -DEMBREE_MAX_ISA=SSE4.2 \
>     %else
>             -DEMBREE_MAX_ISA=NONE \
>     %endif
>
> but the build.log shows:
>
>     + /usr/bin/cmake -DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DLIB_SUFFIX=64 -DBUILD_SHARED_LIBS:BOOL=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_STANDARD=17 -DCMAKE_INSTALL_LIBDIR=/usr/lib64 -DCMAKE_INSTALL_PREFIX=/usr -DEMBREE_COMPACT_POLYS=ON -DEMBREE_IGNORE_CMAKE_CXX_FLAGS=OFF -DEMBREE_ISPC_SUPPORT=ON -DEMBREE_MAX_ISA=DEFAULT -DEMBREE_TUTORIALS=OFF
>
> There is -DEMBREE_MAX_ISA=DEFAULT instead of -DEMBREE_MAX_ISA=NONE.
>
> Morover, I'm not sure whether upstream supports a generic AArch64. README.md
> reads:
>
>     Embree requires at least an x86 CPU with support for
>     SSE2 or an Apple M1 CPU.
>
> -- Petr
>       
>     
    Upstream supported it as I have to scratch build with embree 3.13.3.
    v3.13.4 has a regression due to upstream code change. See
    https://github.com/embree/embree/issues/383
-- 
Luya Tshimbalanga
Fedora Design Team
Fedora Design Suite maintainer

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure