Ok, now I see commits such as: https://src.fedoraproject.org/rpms/ffmpeg/c/70ecae14df6b89cbd269778fc6808eb6e51e141e?branch=rawhidewhich is awful that we need something like this. But @Neal, wouldn't it be better if your `ffmpeg_gen_free_tarball.sh` simply updated the hashes in `sources` file? The `fedpkg new-sources --offline` could help with that I guess.
Vít Dne 10. 05. 22 v 10:10 Vít Ondruch napsal(a):
I somehow don't understand why there should be anything like "unused source files". Why is something like this even possible? It seems strange that this was not questioned originally and it seems still strange nobody questions this in this thread.Vít Dne 04. 05. 22 v 17:01 Ondrej Nosek napsal(a):Hi all,A few months ago fedpkg introduced a change which avoids downloading source files (from dist-git) that are not used in the specfile and therefore downloading them would be wasting of resources and time. The original request was opened here [1] and implemented here [2]. The logic is part of the command "fedpkg sources" and currently can't be disabled manually. The logic parses specfile, but doesn't do a deep analysis, so it is doesn't always right.Recently we got a request for opt-in implementation of this. It means you should actively use some argument (ie. --skip-unused) to avoid downloading unused sources. The requestor points out that it broke the original functionality and it is not possible to add any extra arguments into the complicated release process (RHEL kernel).On the other hand, opt-out (--download-unused) has (I think) a significantly higher impact on saving resources (time and network capacity). Of course, it doesn't have to be implemented as an extra argument, there might be a different (maybe not so clean) solution for such projects.What do you think about it?I added into a loop (bcc) names who already were involved in this in a past (on the Fedora devel mailing list)Thanks, Ondrej [1] https://pagure.io/rpkg/issue/559 [2] https://pagure.io/rpkg/pull-request/564
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
_______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
