Re: dist-git force push

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kamil Dudka <kdudka@xxxxxxxxxx> writes:

> On Friday, April 1, 2022 12:51:36 PM CEST Michael J Gruber wrote:
>
>> - check whether the "new object name" is descendant of
>> (contains) "old build object name" (rather than "old object name", which
>> would forbid any force push)
>> This would allow to rewrite a branch as long as the last commit hasn't been
>> built yet (but allow only rewrites to commits since the last build). In
>> particular, this would allow to avoid the many "commit missing patch",
>> "actually commit the change", "duh" commits which happen after a successful
>> `fedpkg build --scratch --srpm` followed by a half-(how do you say this
>> nicely)ed commit.
>
> I thought the plan was to use pull requests with some CI checks to
> avoid this.

I hope not.  Unless merging the PRs and kicking off the builds are done
automatically, this'll just be as painful as the current centos
workflow:

- commit
- push to fork
- open PR
- wait for checks
- click "merge" button
- wait for bots
- kick off build

compared with:

- fedpkg commit -sc && fedpkg push && fedpkg build

Context switches for maintainers are expensive!  And while I don't
personally think the "oops fixup" commits are a problem, a "PR with CI"
workflow doesn't get rid of them by any means.

Be well,
--Robbie

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Fedora Announce]     [Fedora Users]     [Fedora Kernel]     [Fedora Testing]     [Fedora Formulas]     [Fedora PHP Devel]     [Kernel Development]     [Fedora Legacy]     [Fedora Maintainers]     [Fedora Desktop]     [PAM]     [Red Hat Development]     [Gimp]     [Yosemite News]

  Powered by Linux