> On 3/4/22 10:17 AM, Sérgio Basto wrote: > I think you missed the > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds > (Targeted release: Fedora 33 ) and > https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ I did not. CMake in-source / out-of-source building is an entirely different issue. And I made a good portion of fixing my packages to use the out-of-source build. I even contributed to those CMake guidelines at that time :) As you can see in the Comment #3 in the BZ #2057738, the standard, current, fedora-wide %cmake macro expands to | ... | /usr/bin/cmake \ | -S "." \ | -B "redhat-linux-build" \ | ... And I also mentioned using the -S "." instead of just a 'dot' also workaround the issue. Later in commnet #4 I showed my findings from the upstream code, which IMO strongly suggests, that it should be completely irrelevant how many times, how many ways you define that path, as long as it is always defined the same. Since the CMake command is expanded to /usr/bin/cmake -S . <a_lot_of_Fedora_defines_arguments> . <a_lot_fo_custom_defined_arguments> I believe it should work and thus the current version released to Rawhide is either broken, or ill-documented and the change is badly handled. -- Michal Schorm Software Engineer Core Services - Databases Team Red Hat -- On Fri, Mar 4, 2022 at 4:24 PM Steven A. Falco <stevenfalco@xxxxxxxxx> wrote: > > On 3/4/22 10:17 AM, Sérgio Basto wrote: > > On Fri, 2022-03-04 at 16:04 +0100, Michal Schorm wrote: > >> On Fri, Mar 4, 2022 at 3:40 PM Sérgio Basto <sergio@xxxxxxxxxx> wrote: > >>> The fix is just remove "\ ." (the dot) on %cmake > >> > >> That isn't a fix, that's a workaround for a broken CMake - atleast > >> that I believe, as you can read in that BZ. > >> I haven't found anything on CMake upstream that would suggest such > >> change is needed, I found the contrary. > >> > > > >> And even if this change would be actually intended, it would be nice > >> from the CMake maintainer to announce it. > > > > > > I think you missed the > > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds > > (Targeted release: Fedora 33 ) and > > https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ > > > > > > My deduction also came from here: > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/IGQFBIEBMFHIAHY45SKF5MXOJP43TVQS/ > > > > i.e. the builds that still aren't completely out of the source (i.e. > > have the dot), can have (new) problems, one solution is make the build > > out of the source as recommended on > > https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds > > I removed the "." from the %cmake macros, and the build is progressing properly for rawhide. I still have to make sure that deleting the "." doesn't break F34 through F36. > > Steve > _______________________________________________ > devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx > Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
