On Thu, Jan 27, 2022 at 12:04:02PM +0000, Richard W.M. Jones wrote: > On Thu, Jan 27, 2022 at 12:50:33PM +0100, Vít Ondruch wrote: > > > > Dne 27. 01. 22 v 12:18 Iñaki Ucar napsal(a): > > >On Thu, 27 Jan 2022 at 12:09, Vít Ondruch <vondruch@xxxxxxxxxx> wrote: > > >> > > >>Dne 27. 01. 22 v 11:19 Iñaki Ucar napsal(a): > > >>>On Thu, 27 Jan 2022 at 10:58, Zbigniew Jędrzejewski-Szmek > > >>><zbyszek@xxxxxxxxx> wrote: > > >>>>>I think this change should be reverted until a cleaner way can be > > >>>>>found to implement it. > > >>>>I'm all for making better, but please make concrete proposals. > > >>>Here's a concrete proposal: > > >>> > > >>>- Copy %build_*flags to another private macro, let's say %_build_*flags. > > >>>- Add there the stuff that is not valid once the current build > > >>>finishes (e.g., the flag that this change adds). > > >>>- Use that in %set_build_flags and leave %build_*flags as it was. > > >>> > > >>That sounds similar to > > >>"%extension_cflags/%extension_cxxflags/%extension_ldflags" Zbyszek > > >>already mentioned elsewhere. Or I don't get the point. > > >> > > >>Here is concrete proposal for Ruby: > > >> > > >>https://src.fedoraproject.org/rpms/ruby/pull-request/110 > > >There's a *big* difference: switching to %extension_*flags means that > > >many packages have to be modified > > > > > > But why? In Ruby, it should be enough to change Ruby itself and all > > the other Ruby packages should be fine. Why is it different for > > R/OCAML? > > OCaml is a compiled language, not interpreted. It ships a compiler > which embeds CFLAGS / LDFLAGS (for hardening). But additionally it > ships many libraries that contain link instructions (so they can link > to C libraries), and those also embed LDFLAGS. Hmm, so it sounds like OCaml was actually broken already. For example, if OCaml is linked with -flto or -use-ld=lld, then this should not "leak" into extensions. The split between flags which are appropriate to propagate to extensions and flags which are not is very important, and if it is not followed, extensions would be broken too. > Just about every OCaml package is negatively affected by this change > and they all have to be rebuilt. That doesn't sound good, but if it turns out that they need to be rebuild, I can do that myself. Zbyszek _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
