On Mon, Oct 18, 2021 at 11:01 AM Matthew Miller <mattdm@xxxxxxxxxxxxxxxxx> wrote: > > On Sun, Oct 17, 2021 at 05:33:17PM -0400, Neal Gompa wrote: > > > Now, my makefile is a horrific hand-built thing from literally twenty years > > > ago, and it's probably not up to, like, best pratices of THAT time, let > > > alone now. But I do pass OPTIMIZE="$RPM_OPT_FLAGS" to %make_build in the > > > spec file.... That doesn't seem to include anything about PIE, though. What > > > should I do to make this right? > > > > You should probably pass in %build_cflags and %build_ldflags into your > > makefile. That should fix it. > > It looks like %build_cflags is (literally defined as) %optflags, but I'm > missing the latter. Is this documented in the packaging guidelines? > > It _looks_ like LDFLAGs is supposed to be set automatically in the > environment by %set_build_flags, which gets called by %configure but not by > %make_build, and since my Makefile is hand-built rather than generated with > autotools there is no configure step. So maybe I should just run > %set_build_flags in my spec file? That would work, yes, assuming your Makefile respects it. -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
